chore: attempt to fix docker #5106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ code-server docs for PR #5106 is ready! It will be updated on every commit.
|
Codecov Report
@@ Coverage Diff @@
## main #5106 +/- ##
=======================================
Coverage 71.33% 71.33%
=======================================
Files 30 30
Lines 1685 1685
Branches 374 374
=======================================
Hits 1202 1202
Misses 413 413
Partials 70 70 Continue to review full report at Codecov.
|
code-asher
reviewed
Apr 14, 2022
code-asher
approved these changes
Apr 14, 2022
jsjoeio
force-pushed
the
jsjoeio/temp-docker-fix
branch
from
e3b5e72 to
2380941
Compare
jsjoeio
commented
Apr 14, 2022
| @@ -24,6 +24,7 @@ | |||
| "package": "./ci/build/build-packages.sh", | |||
| "postinstall": "./ci/dev/postinstall.sh", | |||
| "publish:npm": "./ci/steps/publish-npm.sh", | |||
| "publish:docker": "./ci/steps/docker-buildx-push.sh", | |||
There was a problem hiding this comment.
for consistency, i wanted it to be like the publish:npm flow/script.
code-asher
approved these changes
Apr 14, 2022
TinLe
pushed a commit
to TinLe/code-server
that referenced
this pull request
Apr 23, 2022
* chore: attempt to fix docker * Update .github/workflows/docker.yaml Co-authored-by: Asher <[email protected]> * chore: add publish:docker to scripts Co-authored-by: Asher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue publishing v4.0.3 where the action couldn't find the artifacts to download. This changes that flow to download the release assets from the release for the Docker workflow.